Properly handling getenv() returning "" not NULL
i18n code was checking for local-related environment variables
(e.g., "getenv("LANGUAGE")") coming back as a NULL if unset.
However, on my laptop, under Kubuntu 20.04 with GLIBC 2.31, a
"LANGUAGE" env. var. is set, but it's blank.
Tux Paint failed to attempt any fallback (e.g., checking "LANG")
in that situation, which was causing the description text corruption
that was corrected in a previous commit.
That commit also mistakenly suggested that the issue might've been a
difference with GCC versions, but the problem was deeper in Tux Paint's
code (in i18n.c), and was triggered by an unexpected environment.
This commit is contained in:
parent
ac755bf26c
commit
4ba4c11911
2 changed files with 56 additions and 26 deletions
|
|
@ -8,7 +8,7 @@ http://www.tuxpaint.org/
|
|||
|
||||
$Id$
|
||||
|
||||
2020.July.25 (0.9.25)
|
||||
2020.July.26 (0.9.25)
|
||||
* New Features
|
||||
------------
|
||||
* Export drawings:
|
||||
|
|
@ -34,15 +34,20 @@ $Id$
|
|||
(Ref: https://github.com/haikuports/haikuports/issues/3045)
|
||||
Gerasim Troeglazov <3dEyes@gmail.com>
|
||||
|
||||
* Bug Fixes
|
||||
---------
|
||||
* Mended issue where stamp descriptions were not loading
|
||||
when "getenv()" (e.g., "getenv("LANGUAGE")") returned an
|
||||
empty string, rather than a NULL.
|
||||
|
||||
* Mended bug where corrupt text would appear as stamp
|
||||
descriptions, if we failed to know what language to use
|
||||
(see above).
|
||||
|
||||
* Misc
|
||||
----
|
||||
* Improved safety when copying things into string buffers.
|
||||
|
||||
* [WIP] Mending issue where stamp descriptions are not loading,
|
||||
and making things safer when a problem occurs.
|
||||
(Using gcc 9.3.0 compiler, this was happening in 0.9.25 during
|
||||
development, but also affected 0.9.24 and 0.9.23, which worked
|
||||
fine under earlier versions of gcc.)
|
||||
|
||||
2020.April.24 (0.9.24)
|
||||
* New tools
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue