notgne2/tuxpaint-pencil-sharpener
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

"i" wasn't getting reset after goto, causing segfault on Bill's box

Browse source 
("while (i--)" when i was 0 would cause overflow)
This commit is contained in:
William Kendrick 2004-12-12 23:36:41 +00:00
parent 538896a0ab
commit 3481016567
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/tuxpaint.c
View file

@ -3544,6 +3544,9 @@ static multichan *find_most_saturated(double initial_hue, multichan * work,
// find the most saturated pixel near the initial hue guess // find the most saturated pixel near the initial hue guess
multichan *key_color_ptr = NULL; multichan *key_color_ptr = NULL;
double hue_range; double hue_range;
unsigned int orig_i;
orig_i = i;
switch (inf_stamps[cur_stamp]->tinter) switch (inf_stamps[cur_stamp]->tinter)
{ {
@ -3578,8 +3581,11 @@ hue_range_retry:;
upper_hue_2 = upper_hue_1 - 2 * M_PI; upper_hue_2 = upper_hue_1 - 2 * M_PI;
} }
i = orig_i;
while (i--) while (i--)
{ {
//if (i < 10 || i > 20000)
// printf("%d\n", i); fflush(stdout);
mc = work + i; mc = work + i;
// if not in the first range, and not in the second range, skip this one // if not in the first range, and not in the second range, skip this one