notgne2/tuxpaint-pencil-sharpener
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Mended Color Mixer random color bug

Browse source 
If you set a color, then come back to Color Mixer and immediately
dismiss the dialog (without setting a color), an indeterminate
color could appear due to uninitialized variables (new_r, _g, _b).

Closes https://sourceforge.net/p/tuxpaint/bugs/251/
h/t @kentonyanamin on Twitter
This commit is contained in:
Bill Kendrick 2022-06-14 01:14:39 -07:00
parent 7e6f848994
commit 1068a33167
2 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
docs/CHANGES.txt
View file

@ -8,6 +8,13 @@ http://www.tuxpaint.org/
2022.June.14 (0.9.29) 2022.June.14 (0.9.29)
* Bug Fixes:
----------
* Opening and immediately dismissing Color Mixer could cause
an unexpected color to be chosen.
h/t @kentonyanamin on Twitter for reporting.
Closes https://sourceforge.net/p/tuxpaint/bugs/251/
* Other Improvements: * Other Improvements:
------------------- -------------------
* Automatic button size option ("buttonsize=auto"), to scale button * Automatic button size option ("buttonsize=auto"), to scale button

8
src/tuxpaint.c
View file

@ -23209,6 +23209,14 @@ static int do_color_mix(void)
for (i = 0; i < NUM_MIXER_COLORS; i++) for (i = 0; i < NUM_MIXER_COLORS; i++)
color_mixer_color_counts[i] = 0; color_mixer_color_counts[i] = 0;
} }
else
{
new_r = color_hexes[COLOR_MIXER][0];
new_g = color_hexes[COLOR_MIXER][1];
new_b = color_hexes[COLOR_MIXER][2];
}
done = 0; done = 0;
chose = 0; chose = 0;